Ok so the patch issu is resolved. I manually applied the patch (Generals-108-english.exe).
But now when I press play it brings up splash screen for a little while and then thats it. no process running no game.
I guess I won't get it working.
So I have now decided to wait for C&C3 Tiberium Wars that is compatible with Vista-32bit.