Physical CDs for music I particularly like - usually buy from Amazon or eBay, whichever's cheaper. Rip them to lossless for home listening and then to AAC for portable listening.
For everything else and for discovering new music, Spotify Unlimited.
I can never believe it when people say they use YouTube to listen to music. The sound quality of most of the stuff on YouTube is barely better than AM radio...