Little bit of help in C would be appreciated

[spitty!]

Hello all,

Ive just started some coding at uni in c and have written one of my programs up, im down to one error which i can not seem to remove no matter what i do! This is very basic c i guess, probably a little error but its frustrationg me!

/*****************************************************************
 Author: Michael R
 Date: 22nd March 2005
 Purpose: Assignment One - Validating Triangle Sizes
*****************************************************************/

#include <stdio.h>

int main ()
{
     int firstside;
     int secondside;
     int thirdside;
    
     printf("Enter the value of the first side of the triangle: ");
     scanf("%d", &firstside);

     printf("Enter the value of the second side of the triangle: ");
     scanf("%d", &secondside);

     printf("Enter the value of the third side of the triangle: ");
     scanf("%d", &thirdside);
     
     
        if { ((firstside == secondside) && (firstside == thirdside) && (secondside == thirdside)) 
        printf("The first side inputed was %d\n", firstside);
	printf("The second side inputed was %d\n", secondside);
        printf("The third side inputed was %d\n", thirdside);
        printf("As a result this is a equilateral triangle as all three sides are of equal length.");
           }    
           
        else
	   if { ((firstside == secondside) || (firstside == thirdside) || (secondside == thirdside))
    	   printf("The first side inputed was %d\n", firstside);
	   printf("The second side inputed was %d\n", secondside);
           printf("The third side inputed was %d\n", thirdside); 
           printf("As a result this is a Isosceles triangle as two of the three sides are of equal length.");
              } 
          
            else
	       if { ((firstside != secondside) && (firstside != thirdside) && (secondside != thirdside))
	       printf("The first side inputed was %d\n", firstside);
	       printf("The second side inputed was %d\n", secondside);
               printf("The third side inputed was %d\n", thirdside); 
	       printf("As a result this triangle has no sides of equal length and hence is a scalene triangle.");
                  }

              else 
                  printf("The first side inputed was %d\n", firstside);
		  printf("The second side inputed was %d\n", secondside);
                  printf("The third side inputed was %d\n", thirdside); 
                  printf("The inputed sides do not create a  valid triangle as the addition two sides are not greater than the third side ");	
                   

     return(0);
}

The error i am recieving is on line 25 the first if statement I cant seem to remove it, this is the output i get when trying to compile.

Borland C++ 5.5.1 for Win32 Copyright (c) 1993, 2000 Borland
g:\ict102\assessment1\test.c:
Error E2376 g:\ict102\assessment1\test.c 25: If statement missing ( in function main
*** 1 errors in Compile ***


If any1 could steer me in the right direction it would be a great help.

Cheers,

Michael

[LWA]

IIRC a C if loop should be written:

if (Condition)
{
do some code
}

Your curly brackets are not outside of the loop condition.

So

if ((firstside == secondside) && (firstside == thirdside) && (secondside == thirdside))
{ 
        printf("The first side inputed was %d\n", firstside);
	printf("The second side inputed was %d\n", secondside);
        printf("The third side inputed was %d\n", thirdside);
        printf("As a result this is a equilateral triangle as all three sides are of equal length.");
}

Hope this helps,
Leon

[spitty!]

ahhh cheers for that

i havent done the loops yet only started the course recently

Much appreciated

[yamangman]

Before you go any other it should be pointed out that an if...else statement is NOT a loop, don't go away thinking that it is!

[LWA]

ahhh cheers for that

i havent done the loops yet only started the course recently

Much appreciated

Anytime mate, here at Hexus you will always find people willing to help

[Kezzer]

Before you go any other it should be pointed out that an if...else statement is NOT a loop, don't go away thinking that it is!

lmao so true. That's the true programming peril, not understanding something

[Spud1]

you can also declare variables of the same type all on one line, like this (if you want to)

      int firstside, secondside, thirdside;

Not a vital thing, but its good programming practice, makes it ever so slightly faster to compile and read

[suryad]

Out of curiosity what class was it for? I just got my Bachelors in CS from UC Davis here in California.

[spitty!]

arrrrgg, its getting me so frustrated i still cant get it work, properly. oh well ill leave it for a few days and come back to it.

Im trying to do another one for uni with while loops, same errors keep on plauging my code that i cant remove!

Im in First Year uni, the course is "intro to computer science" im doing a networking degreee

I wish that my tutor had time to look and help me with my work, when ever she gets aroudn to me, the tutorial is over, so im fending on my own

My latest attempt at a new program for one of my tut's

/*****************************************************************
 Author: Michael R
 Date: 30th March 2005
 Purpose: ASCII Values
*****************************************************************/

#include <stdio.h>


int main ()
{
	int mychar, uppercase, lowercase;
        
      	printf("Please enter a letter of the alphabet for the ASCII value of the haracter:");
     	printf("Alternatively enter # to exit this program");
        scanf("%c%*c", &mychar);

	uppercase = mychar + 32;
	lowercase = mychar - 32;
       	
	while(mychar =! '#')
        {
               	if { (65<= mychar <=90)  
	 	printf("The ASCII value is equal to %d and as a capital letter is equal to %d\n" mychar, uppercase);
               	   }
	
                  	if { (92<= mychar <=122)
			printf(" The ASCII value is equal to %d and as a lowercase letter is equal to %d\n" mychar, lowercase);  	
                           }
                             	
                     else{
                     printf("The user input is not a valid character, please try again");
	                  }
        		printf("Please enter a letter of the alphabet for the ASCII value of the character:");
     			printf("Alternatively enter # to exit this program");
       			scanf("%c%*c", &mychar);

			uppercase = mychar + 32;
			lowercase = mychar - 32;
	}     
		return(0);
}

Borland C++ 5.5.1 for Win32 Copyright (c) 1993, 2000 Borland
g:\ict102\lab\week4lab\ascii.c:
Warning W8060 g:\ict102\lab\week4lab\ascii.c 21: Possibly incorrect assignment in function main
Error E2376 g:\ict102\lab\week4lab\ascii.c 23: If statement missing ( in function main
Warning W8004 g:\ict102\lab\week4lab\ascii.c 43: 'lowercase' is assigned a value that is never used in function main
Warning W8004 g:\ict102\lab\week4lab\ascii.c 43: 'uppercase' is assigned a value that is never used in function main
*** 1 errors in Compile ***


Can any1 explain these warnings :S or why it doesn't want to accept my while function

[yamangman]

Heheh, you've made the same mistake as before, your curly braces come AFTER REPEAT AFTER the condition in an if statement (see big leons original post). Additionally, it appears your if statement conditions are incorrect. You have also unnecessarily reproduced code in your while loop.

Get used to not getting help from tutors. Buy a book, do some research and figure it out on your own. If people do help, actually listen and take in what they say though.

[Kensia]

The while loop test should be '!=' not '=!'.

[DavidM]

Thats the trouble with compilers, the error doesnt make itself obvious immediately like code acted on on run-time. (As a former assembly language coder, you have my sympathies!)

[spitty!]

cheers for the advice guys, im gonna dive back into the pool of c and see what i can do

Yeah i think i might buy another book when i have the finances, my text book for the course is like 100% algorithims hehe i need another1 on jus code

ive finnished c now for the semester one ive done these last things, next week its onto java