.NET Txt File Line counter

[Shadow_101]

Basicly at the moment I’ve got a file being read in, and then lines in the file being counted (this will eventually help build and array to hold the data).

However at the moment it’s not counting the lines at all. I’m not sure what’s wrong with the code it looks fine to me. Hoping a fresh pair of eyes might point out what I’ve done wrong!

Public Class MicroMouse
    Inherits System.Windows.Forms.Form
Private MMDATA As System.IO.StreamReader

    Dim MMFile As String
   
 Private Sub BtnOpenFile_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles BtnOpenFile.Click

        OFDMicroData.Title = "Locate Micro Mouse Source File"
        OFDMicroData.Filter = "MicroMouse TAB Seperated File (*.txt)| *.txt"

        If (OFDMicroData.ShowDialog() = DialogResult.OK) Then
            MMFile = OFDMicroData.FileName
            MMDATA = System.IO.File.OpenText(MMFile)
            LBOpenedFile.Text = MMFile

        Else
            MsgBox("Please Select a valid MicroMouse Data File", MsgBoxStyle.Exclamation, "File Not Selected")
            LBOpenedFile.Text = "Error No File Selected"
        End If
        LineCounter()
    End Sub
    Private Sub LineCounter()
        Dim Curline, Letter As String
        Dim i, CharsInFile, LineCount As Short
        LineCount = 0
        CharsInFile = MMFile.Length
        For i = 0 To CharsInFile - 1
            Letter = MMFile.Substring(i, 1)
            If Letter = Chr(13) Then
                LineCount += 1
                i += 1
            End If

        Next i
        LBcount.Text = LineCount
    End Sub
End Class

[joeka]

I'm not an expert when it comes to .NET - I'm learning myself..
But I recently did something similar - you might find it easier to use the Readline method - if Readline returns Nothing, then you are at the end of the stream.

For example:

    Private Sub LineCounter()
        LineCount = 0
        Dim sLine As String = IOStreamReader.ReadLine
        While Not sPC Is Nothing
             LineCount += 1
             sLine = IOStreamReader.ReadLine
        End While
        LBcount.Text = LineCount
    End Sub

Hope this is of some help!

[Stoo]

I spotted a post about this on another forum from a Microsoft Dev:

Dim LineCounter As Integer
Dim LineText As String
Dim MyStream As New System.IO.StreamReader("c:\test.txt")
Do Until MyStream.Peek = -1
	LineText = MyStream.ReadLine
	LineCounter += 1
Loop
MessageBox.Show("This file contains " & LineCounter & " lines.")

Might do the trick?

[TheAnimus]

it should in theory be faster to just look for the \r or \n char. Because this way, a string has to be stacked each time, more memory is used (which has to be garbage collected etc.).

My VB.net is terrible, so i'll not even try to write it, but i hope you can get the idea (if not i'll C# it up!)

[Stoo]

In classic it's just vbCRLF, I'm not that far into .NET yet..

[Shadow_101]

I spotted a post about this on another forum from a Microsoft Dev:

Dim LineCounter As Integer
Dim LineText As String
Dim MyStream As New System.IO.StreamReader("c:\test.txt")
Do Until MyStream.Peek = -1
	LineText = MyStream.ReadLine
	LineCounter += 1
Loop
MessageBox.Show("This file contains " & LineCounter & " lines.")

Might do the trick?

Cheers! Worked a charm with a bit of editing. Thanks for all your responses guys!