Again, thanks for the info all helpin alot and will also post all this on our guild forum
The rogues we use for ZG two of the have SC full kit, Knol blade +rends off hand which i can say is very nice. I use Knol blade in main hand Lobo (AV dagger) in offhand, i have split ALOT of my kit up, My chance to crit is not TO high but is nice enough to crit quite offen (19.XX%) I have around +4% extra chance to HIT (and plus the +5% though talents) but ALOT of Str and Stam. IMO Combat spec rogues are much much better for PvE as you said you need to maintain DPS which a combat rogue can do without a doubt and is one of the reasons we have done quite well for our 3rd run (IMO anyways)
i cant realllly comment to much on the caster side or other melee/ranged
Only problem i find is trying to explain to the other two rogues that the reason i wipe the floor with their DPS is SLICE AND DICE! omg -.- why dont ALL rogues use this? i use it as my second finisher in any fight... normally if fighting elites like in ZG it would be a 3 or 4 point evis and one or two point slice and dice next and normally compared to the 2 rogues who dont use it i come around around 7 - 10% more then them in overall damage (not sure about the % higher on DPS never checked)