Any Javascript Guru's?

[Vini]

<script type="text/javaScript">
<!--
function getCookie(name) {
  var dc = document.cookie;
  var prefix = name + "=";
  var begin = dc.indexOf("; " + prefix);
  if (begin == -1) {
    begin = dc.indexOf(prefix);
    if (begin != 0) return null;
  } else
    begin += 2;
  var end = document.cookie.indexOf(";", begin);
  if (end == -1)
    end = dc.length;
  return unescape(dc.substring(begin + prefix.length, end));
}

// LIST ALL SHOW/HIDE ELEMENT IDS HERE
menus_array = new Array ('ddIT', 'ddLegal', 'ddMining', 'ddEnergy', 'ddChemicals', 'ddConstruction', 'ddAviation', 'ddServices');
menus_status_array = new Array ();// remembers state of switches
img_close = 'http://www.ibeats.co.uk/wp-content/themes/ibeats/images/collapse.gif';
img_open = 'http://www.ibeats.co.uk/wp-content/themes/ibeats/images/expand.gif';

function showHideSwitch (theid) {
  if (document.getElementById) {
    var switch_id = document.getElementById(theid);
    var imgid = theid+'Button';
    var button_id = document.getElementById(imgid);
    if (menus_status_array[theid] != 'show') {
      button_id.setAttribute ('src', img_close);
      switch_id.className = 'showSwitch';
	  menus_status_array[theid] = 'show';
	  document.cookie = theid+'=show';
    }else{
      button_id.setAttribute ('src', img_open);
      switch_id.className = 'hideSwitch';
	  menus_status_array[theid] = 'hide';
	  document.cookie = theid+'=hide';
    }
  }
}
function resetMenu () { // read cookies and set menus to last visited state
  if (document.getElementById) {
    for (var i=0; i<menus_array.length; i++) {
      var idname = menus_array[i];
      var switch_id = document.getElementById(idname);
      var imgid = idname+'Button';
      var button_id = document.getElementById(imgid);
      if (getCookie(idname) == 'show') {
	    button_id.setAttribute ('src', img_close);
        switch_id.className = 'showSwitch';
	    menus_status_array [idname] = 'show';
	  }else{
	    button_id.setAttribute ('src', img_open);
        switch_id.className = 'hideSwitch';
	    menus_status_array [idname] = 'hide';
	  }
    }
  }
}
//-->
</script>

This code is for a show/hide div, but it's defaulting as 'hide' - as seen here to the right of the page...

Any idea how to set it to open as default?

[moogle]

you could put in the body tag onload=showHide(DDIt)

[Tomahawk]

This code is for a show/hide div, but it's defaulting as 'hide' - as seen here to the right of the page...

Any idea how to set it to open as default?

Seems to be line 118 of your page, which read:

if (getCookie(idname) == 'show') {

Which if you want it to open by default should be changed to read:

      if (getCookie(idname) != 'show') {

That should sort the problem... or you could use the method mentioned by moogle.

Think I've misunderstood something in your code hah... worth trying. Also worth noting your menu does open by default when the page loads but it is immediately closed.. so I'm guessing its something to do with the cookie possibly?!

[Vini]

Seems to be line 118 of your page, which read:

if (getCookie(idname) == 'show') {

Which if you want it to open by default should be changed to read:

      if (getCookie(idname) != 'show') {

That should sort the problem... or you could use the method mentioned by moogle.

Think I've misunderstood something in your code hah... worth trying. Also worth noting your menu does open by default when the page loads but it is immediately closed.. so I'm guessing its something to do with the cookie possibly?!

Ok, applied this 'fix', anyone able to confirm it does indeed open, and stay open when visiting?

[Tomahawk]

I'm getting this error being flagged:

button_id has no properties
iBeats.co.uk
Line 118

From your code I don't really understand what you've used the cookie for to be honest? ..but it is definitely to do with the cookie you are creating and setting with the open/close state. As I just blocked cookies from your domain and did a hard refresh and the menu stayed open by default.

[TAKTAK]

the menu is default open for me

[Vini]

I'm getting this error being flagged:



From your code I don't really understand what you've used the cookie for to be honest? ..but it is definitely to do with the cookie you are creating and setting with the open/close state. As I just blocked cookies from your domain and did a hard refresh and the menu stayed open by default.

Cookie is used to remember the state of the menu on users visit...

[yamangman]

Ok, applied this 'fix', anyone able to confirm it does indeed open, and stay open when visiting?

Why not delete the cookie and test it yourself?